Yaniv Bronhaim has posted comments on this change. Change subject: net_func_tests: Rollback only when an error happens ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29817/4/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1918: finally: Line 1919: addrFlush(nic) Line 1920: Line 1921: @permutations([[False], [True]]) Line 1922: @cleanupNet > what is that? how is it related? missed the context. ignore it Line 1923: def testBrokenNetworkReplacement(self, bridged): Line 1924: with dummyIf(1) as nics: Line 1925: nic, = nics Line 1926: network = {NETWORK_NAME: {'nic': nic, 'vlan': VLAN_ID, -- To view, visit http://gerrit.ovirt.org/29817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb9bf19f4bf63d3705cfdda92aa6ec7513a8b98 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
