mooli tayer has posted comments on this change. Change subject: net_func_tests: Rollback only when an error happens ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29817/4/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 416: self.assertIn(bondName, netinfo.bondings) Line 417: self.assertEqual(netinfo.bondings[bondName]['active_slave'], '') Line 418: Line 419: @cleanupNet Line 420: @RequireVethMod I understand this is intentional: For all tests you want to clean only on exception AND you want to add another missing @cleanupNet. Line 421: @ValidateRunningAsRoot Line 422: def test_getVdsStats(self): Line 423: """This Test will send an ARP request on a created veth interface Line 424: and checks that the TX bytes is in range between 42 and 384 bytes -- To view, visit http://gerrit.ovirt.org/29817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb9bf19f4bf63d3705cfdda92aa6ec7513a8b98 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
