Bala.FA has posted comments on this change. Change subject: gluster: add createBrick verb ......................................................................
Patch Set 12: (3 comments) http://gerrit.ovirt.org/#/c/35498/12/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 29: Line 30: import fstab Line 31: import exception as ge Line 32: from vdsm import utils Line 33: import storage.mount as mount > I will arrange the imports as follows. Please correct me if anything to be The idea is 1. Have python system modules as first level 2. Have vdsm modules as second level 3. Have local modules as third level Line 34: Line 35: Line 36: _pvcreateCommandPath = utils.CommandPath("pvcreate", Line 37: "/sbin/pvcreate", Line 205: '-K', '-i', 'size=512', '-d', Line 206: '-sw=%sk' % alignment, Line 207: '-su=%sk' % stripeSize, Line 208: '-n', 'size=8192', Line 209: devPath]) > ok for point no 1 and 2. 3. OK Line 210: if rc: Line 211: raise ge.GlusterHostStorageDeviceMkfsFailedException(devPath, Line 212: alignment, Line 213: stripeSize) Line 285: 'model': thinlv.model, Line 286: 'fsType': DEFAULT_FS_TYPE, Line 287: 'mountPoint': mountPoint, Line 288: 'uuid': thinlv.format.uuid or '', Line 289: 'createBrick': False} > Hope i can do it in a separate enhancement path after this got merged becau Why not have this patch dependent on the new patch which have the fix? -- To view, visit http://gerrit.ovirt.org/35498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
