Bala.FA has posted comments on this change. Change subject: gluster: add createBrick verb ......................................................................
Patch Set 15: Code-Review-1 (2 comments) address comments in patch set #12 and #15 http://gerrit.ovirt.org/#/c/35498/15/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 212: if rc: Line 213: raise ge.GlusterHostStorageDeviceMkfsFailedException(devPath, Line 214: alignment, Line 215: stripeSize, Line 216: fsType) 1. why are not out/err considered here? 2. Isn't it valid to return True if it successfully completed? Line 217: if fsType == DEFAULT_FS_TYPE: Line 218: _formatDeviceXfs() Line 219: else: Line 220: log.error("This file system type:%s will not be supported" % fsType) Line 216: fsType) Line 217: if fsType == DEFAULT_FS_TYPE: Line 218: _formatDeviceXfs() Line 219: else: Line 220: log.error("This file system type:%s will not be supported" % fsType) Have it clean msg like '%s is currently unsupported' Line 221: raise ge.GlusterHostStorageDeviceMkfsFailedException(devPath, Line 222: alignment, Line 223: stripeSize, Line 224: fsType) -- To view, visit http://gerrit.ovirt.org/35498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
