Ondřej Svoboda has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager ......................................................................
Patch Set 2: (1 comment) What "now" means. http://gerrit.ovirt.org/#/c/37041/2//COMMIT_MSG Commit Message: Line 10: dnsmasq and dhclient on the respective sides) it was previously enough to set Line 11: an address on the client side to stop NetworkManager from running its own Line 12: dhclient on it. Line 13: Line 14: Now this approach is useless. On the server side, NetworkManager automatically > what do you mean by "Now"? A year ago, when writing testDhclientLeases, not really aware of NM_CONTROLLED=no yet, I invented the original hack to assign an address to the client side of the veth pair so NetworkManager would not run dhclient on it. I did not worry about the server (dnsmasq) side but I kind of remember it was getting an address. Back then I verified the functionality on Fedora 20 and RHEL 6.5, now I test on RHEL 7 so there was a major change in NetworkManager. I don't think it's necessary to pinpoint the version of NM that allowed this hack but ask me if you think it is :-) http://gerrit.ovirt.org/#/c/23098/ Line 15: takes the veth up, so we cannot even assign an address to it, and the test is Line 16: skipped. Line 17: Line 18: Let's remove the broken code now. -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches