Francesco Romani has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37509/3/vdsm/v2v.py File vdsm/v2v.py: Line 97: os.remove(file_name) Line 98: Line 99: _jobs.pop(jobId) Line 100: if len(_jobs) > 0: Line 101: kill_zombie_jobs() why here? this somehow suggest that only one import using virt-v2v may be active at time. Is that really true? If so it is a very important constraint and should be documented and enforced explicitely. Line 102: return ovf Line 103: Line 104: Line 105: def kill_zombie_jobs(): -- To view, visit http://gerrit.ovirt.org/37509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
