Dan Kenigsberg has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37509/4/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 154: EXT_UDEVADM = '@UDEVADM_PATH@' Line 155: Line 156: EXT_UMOUNT = '@UMOUNT_PATH@' Line 157: Line 158: EXT_VIRT_V2V = '@VIRT_V2V_PATH@' Please use CommandPath; constats.py junkyard is to be retired. Line 159: Line 160: EXT_VDSM_RESTORE_NET_CONFIG = '@VDSMDIR@/vdsm-restore-net-config' Line 161: EXT_VDSM_STORE_NET_CONFIG = '@VDSMDIR@/vdsm-store-net-config' Line 162: -- To view, visit http://gerrit.ovirt.org/37509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
