Nir Soffer has posted comments on this change.

Change subject: virt: Check if a drive is chuhked before extending
......................................................................


Patch Set 5: Verified+1

Verified live merge on Fedora 21:

- create disk
- create snapshot while installing os on disk
- delete snapshot while installing os on disk
- reboot when installation finished

Tested with file and block storage and thin and preallocated disks.

Testing reveal these bugs in current code:
- We try to extend base raw volume
- We try to perform pointless extensions where new size <= current size

These pointless extend attempts fail when calling lvm with this error:

cb42e98a-b200-4228-9abc-957cd73022f9::DEBUG::2015-02-13 
09:02:18,879::lvm::301::Storage.Misc.excCmd::(cmd) FAILED: <err> = "  WARNING: 
lvmetad is running but disabled. Restart 
lvmetad before enabling it!\n  New size given (16 extents) not larger than 
existing size (32 extents)\n  Run `lvextend --help' for more information.\n"; 
<rc> = 3

These issues exists in current code are not effected by this patch. I will
handle them in later patch.

-- 
To view, visit http://gerrit.ovirt.org/37573
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to