Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Check if a drive is chuhked before extending ......................................................................
virt: Check if a drive is chuhked before extending Previously extendDriveVolume() was checking if a drive is a block device and assumed that callers checked the drive format. The check was unneeded when called from extendDrivesIfNeeded(), and spreading the logic between different methods makes the code harder to understand. Now extendDriveVolume() requires that callers are doing the required checks and callers are checking Drive.chunked before calling it. When we support LSM between mixed storage domain, Drive.chunked will encapsulate the logic for handling replication of file-based drive to block based storage domain. In merge(), we are always dealing with cow volumes, so checking for blockDev is enough. Using Drive.chunked for clarity. Change-Id: I48416dde002272d45761296f176b97f4d870849d Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/37573 Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 13 insertions(+), 9 deletions(-) Approvals: Nir Soffer: Verified Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
