Daniel Erez has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37785/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 618: return int(size) Line 619: Line 620: def getVAllocSize(self, imgUUID, volUUID): Line 621: """ Returns block volume true size in bytes. """ Line 622: return self.produceVolume(imgUUID, volUUID).getVolumeTrueSize(bs=1) The engine treats 'truesize' as actual size (as opposed to 'apparentsize' which represents the virtual size - the size that is visible to the VM). So I think we should simply switch the logic of these functions (getVSize and getVAllocSize) to correlate the behavior of fileSD - just need to be careful with the current usages of 'getVSize'... :) Line 623: Line 624: def validateCreateVolumeParams(self, volFormat, srcVolUUID, Line 625: preallocate=None): Line 626: super(BlockStorageDomain, self).validateCreateVolumeParams( -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
