Nir Soffer has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ......................................................................
Patch Set 5: Verified-1 This is not going to work, there is code like Image.copyCollapse that assume that Volume.getVolumeParams() can be called without preparing an image, so we currently we cannot implement getVolumeSize using qemu-img. We have the volume size in the metadata block of the volume, which should be the virtual size of the volume, maybe we should use it for apparentsize, or as a fallback if the device does not exists. -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
