Shahar Havivi has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/37509/7/vdsm/v2v.py File vdsm/v2v.py: Line 219: Line 220: def _handle_process_input(self, proc): Line 221: re_copy_disk = re.compile(r'.*(Copying disk \d+/\d+).*') Line 222: while not self._abort: Line 223: line = proc.stdout.readline() > it seems that _handle_process_input() actually parses the *output* of v2v. sure the test will be challenging... I don't think that it should be out of the class since it is part of the import and there are a lot of reference to for progress, status, abort_msg and handle_process_errors. Line 224: Line 225: if line == '': Line 226: self._handle_process_errors(proc) Line 227: break -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
