Francesco Romani has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/37509/7/vdsm/v2v.py File vdsm/v2v.py: Line 97: def get_converted_vm(jobId): Line 98: global _jobs Line 99: with _lock: Line 100: if jobId not in _jobs: Line 101: errCode['invalidV2VJob'] ok but we need a 'return' here :) Line 102: elif _jobs[jobId].status != 'done': Line 103: errCode['V2VJobNotDone'] Line 104: Line 105: try: Line 99: with _lock: Line 100: if jobId not in _jobs: Line 101: errCode['invalidV2VJob'] Line 102: elif _jobs[jobId].status != 'done': Line 103: errCode['V2VJobNotDone'] same Line 104: Line 105: try: Line 106: file_name = os.path.join(_P_V2V_DIR, "%s.ovf" % jobId) Line 107: with open(file_name, 'r') as f: -- To view, visit http://gerrit.ovirt.org/37509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
