Timothy Asir has uploaded a new change for review.
Change subject: moved metadatasize as an optional param for pv create in lvm
module
......................................................................
moved metadatasize as an optional param for pv create in lvm module
Specifying the metadata area using metadatasize is not a
mantatory its just an option to pvcreate command.
There are some situations like when a volume group contains
many physical volumes, having many redundant copies of
metadata (on every physical volume) is inefficient.
Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3
Signed-off-by: Timothy Asir <tjeya...@redhat.com>
---
M vdsm/storage/lvm.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/38188/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index aa3c04b..2a85e39 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -692,7 +692,7 @@
return pv
-def _createpv(devices, metadataSize, options=tuple()):
+def _createpv(devices, metadataSize=0, options=tuple()):
"""
Size for pvcreate should be with units k|m|g
pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
@@ -702,8 +702,9 @@
cmd = ["pvcreate"]
if options:
cmd.extend(options)
- cmd.extend(("--metadatasize", metadatasize, "--metadatacopies", "2",
- "--metadataignore", "y"))
+ if metadataSize:
+ cmd.extend(("--metadatasize", metadatasize, "--metadatacopies", "2",
+ "--metadataignore", "y"))
cmd.extend(devices)
rc, out, err = _lvminfo.cmd(cmd, devices)
return rc, out, err
--
To view, visit https://gerrit.ovirt.org/38188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeya...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
