Ido Barkan has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38281/5/tests/vdsmDumpChainsTests.py File tests/vdsmDumpChainsTests.py: Line 22: Line 23: from vdsm_dump_chains import _volume_dict_to_volume_chains Line 24: Line 25: Line 26: class vdsmDumpChainsTest(TestCaseBase): > also test the base where there is no parent (parent is BLANK_UUID) Done Line 27: def test_single_chain(self): Line 28: d = {'a': 'b', 'b': None} Line 29: self.assertEqual(_volume_dict_to_volume_chains(d), [['a', 'b', None]]) Line 30: Line 28: d = {'a': 'b', 'b': None} Line 29: self.assertEqual(_volume_dict_to_volume_chains(d), [['a', 'b', None]]) Line 30: Line 31: def test_two_disconnected_chains(self): Line 32: d = {'a': 'b', 'c': 'd', 'b': None, 'd': None} > there is no such case (to chains) Done Line 33: self.assertEqual( Line 34: _volume_dict_to_volume_chains(d).sort(), Line 35: [['a', 'b', None], ['c', 'd', None]].sort()) Line 36: -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
