Yaniv Bronhaim has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/38281/7/client/vdsm-dump-chains.in File client/vdsm-dump-chains.in: Line 3: CLIENT="@VDSMDIR@/vdsm_dump_chains.py" Line 4: [ -e "$CLIENT" ] || CLIENT="$CLIENT"c Line 5: Line 6: [ -n "$PYTHONPATH" ] && PYTHON_FORMATTED_PATH=":$PYTHONPATH" Line 7: PYTHONPATH="@VDSMDIR@$PYTHON_FORMATTED_PATH" python "$CLIENT" "$@" > or, we can simply place the new python module here. no. how is it related to vdsm client? either part vdsm-tool or under storage or be part of vdsm api and run it with vdsClient. it sounds and looks like helper utility, I don't see any reason to not include it as vdsm-tool verb. -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
