Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38679/2/vdsm/API.py File vdsm/API.py: Line 1378: Line 1379: return dict(status=doneCode) Line 1380: Line 1381: # VM-related functions Line 1382: def getVMList(self, fullStatus=False, vmList=(), onlyUUID=True): we learned the hard and painful way how VDSM proper uses this API, and where and how it could break. Now let's see how MOM uses it. mom $ git grep getVMList mom/HypervisorInterfaces/vdsmInterface.py:56: response = self.vdsm_api.getVMList(True, [uuid]) mom/HypervisorInterfaces/vdsmInterface.py:65: response = self.vdsm_api.getVMList(True, [uuid]) mom/HypervisorInterfaces/vdsmInterface.py:75: response = self.vdsm_api.getVMList() so, we have one call with all the default values. And so we must make sure the default values are correct also for MOM case. Which means we'll most likely need to switch the default value for 'onlyUUID'. Line 1383: """ return a list of known VMs with full (or partial) config each """ Line 1384: # To improve complexity, convert 'vms' to set(vms) Line 1385: vmSet = set(vmList) Line 1386: vmlist = [v.status(fullStatus) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
