Dan Kenigsberg has posted comments on this change. Change subject: API: onlyUUID should affect only short status ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py File vdsm/API.py: Line 1385: vmSet = set(vmList) Line 1386: vmlist = [v.status(fullStatus) Line 1387: for v in self._cif.vmContainer.values() Line 1388: if not vmSet or v.id in vmSet] Line 1389: if not fullStatus and onlyUUID: > Strictly speaking, I think we don't. onlyUUID was born with an intention to change only the fullStatus=False behaviour. I did not intend it to override the ancient fullStatus=True. Therefore, I prefer to include this change, and DOCUMENT it in the schema. However, now that we know that this change does not solve the woes of mom, the commit message should be changed. Line 1390: # BZ 1196735: api backward compatibility issue Line 1391: # REQUIRED_FOR: engine-3.5.0 only Line 1392: vmlist = [v['vmId'] for v in vmlist] Line 1393: return {'status': doneCode, 'vmList': vmlist} -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
