Piotr Kliczewski has posted comments on this change. Change subject: gluster: add createBrick verb ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/35498/13/vdsm/gluster/apiwrapper.py File vdsm/gluster/apiwrapper.py: Line 80: Line 81: def storageDevicesList(self, options=None): Line 82: return self._gluster.storageDevicesList() Line 83: Line 84: def createBrick(self, name, mountPoint, devList, raidParams): > Will it be ok to have raidParams={} or it should be like raidParams=None It is up to you which default value to use but please be consistent with api.py. Line 85: return self._gluster.createBrick(name, mountPoint, Line 86: devList, raidParams) Line 87: Line 88: -- To view, visit http://gerrit.ovirt.org/35498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches