Piotr Kliczewski has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35498/16/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 1284: # @devList:    List of devices to be used
Line 1285: #
Line 1286: # @fsType:     # optional file system type
Line 1287: #
Line 1288: # @raid:       # optional dictonary contains raid details of a raid 
device
Please keep param names consistent between description and command definition. 
You use raid in description and raidParams in definition.
Line 1289: #
Line 1290: # Returns:
Line 1291: # Success or failure
Line 1292: #


-- 
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to