Piotr Kliczewski has posted comments on this change. Change subject: asyncore: dynamic tick support ......................................................................
Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/37057/8/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 81: return getattr( Line 82: self.__impl, Line 83: "next_check_interval", Line 84: lambda self: None Line 85: )(self) > the combined usage of lambda and getattr made this snippet hard to process. Will explore options to see how to make it more readable Line 86: Line 87: def recv(self, buffer_size): Line 88: try: Line 89: data = self.socket.recv(buffer_size) Line 168: for disp in self._map.itervalues(): Line 169: if hasattr(disp, "next_check_interval"): Line 170: interval = disp.next_check_interval() Line 171: if interval is not None and interval >= 0: Line 172: timeout = min(interval, timeout) > this for loop above could be extracted ina function which will make it more Done Line 173: Line 174: asyncore.loop( Line 175: timeout=timeout, Line 176: use_poll=True, https://gerrit.ovirt.org/#/c/37057/8/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 444: return(self._outgoing_heartbeat_in_milis / 1000.0) - since_last_update > Does this pass pep8? As you can see in jenkins comment pep8 is happy about it. -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
