Piotr Kliczewski has posted comments on this change. Change subject: asyncore: dynamic tick support ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 448: def next_check_interval(self, dispatcher): Line 449: if self._outgoingHeartBeat == 0: Line 450: return None Line 451: Line 452: return max(self._outgoing_heartbeat_expiration_interval, 0) > Done I will add more tests in followup patches. We need to test stomp protocol implementation better. Line 453: Line 454: def handle_write(self, dispatcher): Line 455: if self._outbuf is None: Line 456: try: -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
