Martin Sivák has posted comments on this change. Change subject: API: onlyUUID should affect only short status ......................................................................
Patch Set 4: Code-Review-1 Here are my comments to the way this is fixed. I learned three things after I discussed this with Dan and Francesco: 1) MOM is the only direct consumer of API.py 2) The issue is only in engine's usage of JSONRPC and does not hit XMLRPC 3) The engine only consumes API.py through the Bridge Taking those three points into account we should fix the issue (change the default behaviour) in the Bridge implementation. That way MOM will still see what it expects, no compatibility issues will appear and the bug will be just as gone. So Piotrs comment about changing the default in the 3rd revision is right (engine in 3.5), but at the wrong place. We should change the default for JSONRPC and keep API intact to stay MOM compatible. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
