Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
......................................................................
Patch Set 4:
Given the last concerns about MOM compatibility (being a proper Fedora Package,
may break some 3.3/3.4 setups)
assuming we do want to follow onlyUUID with fullStatus=False only, so we want
this patch in:
I did a careful review of all the possible flows, and it seems that
- in XMLRPC, we always set explicitely onlyUUID=False, so no room for breakage
- in JSONRPC, we have Host_getVMList_Call (short status!), on which
- if onlyUUID is provided from the outside, we use it (Engine >= 3.5.1)
- if onlyUUID is NOT given (Engine 3.5.0), we default as True,
and doing so we preserve the backward compatibility
- in JSONRPC, in Host_getVMFullList_Call (full status), we use onlyUUID=False
explicitely, so no issue hee
So, if the above analysis is correct, it seems we always pass the correct value
to onlyUUID and, moreover, we never relies on its default values.
Then, it seems legit to switch the default values to the one which also
preserves MOM backward compatibility (onlyUUID=False), because
- in API.py, we need to be backward compatible with MOM, which calls
getVMList both with FullStatus=True and without any arguments.
Please review the above and tell me what is wrong. If everything's right, we
may able to just switch default, drop the MOM patch(es) and fix the remaining
issues with just this patch.
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
