Michal Skrivanek has posted comments on this change. Change subject: stomp: server side subscriptions ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 21: from vdsm.utils import monotonic_time Line 22: import re Line 23: Line 24: LEGACY_SUB_ID_REQ = "/queue/_local/vdsm/requests" Line 25: LEGACY_SUB_ID_RES = "/queue/_local/vdsm/reponses" typo. can you do a global grep, i see it in random places in other reviews too... Line 26: Line 27: _RE_ESCAPE_SEQUENCE = re.compile(r"\\(.)") Line 28: Line 29: _RE_ENCODE_CHARS = re.compile(r"[\r\n\\:]") -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
