Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 126: subs = self._sub_dests[destination] Line 127: except KeyError: Line 128: self._sub_dests[destination] = [subscription] Line 129: else: Line 130: subs.append(subscription) > you may want to try defaultdict to simplify this code. Will try Line 131: Line 132: self._sub_ids[sub_id] = subscription Line 133: Line 134: def _send_error(self, msg, connection): -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
