Francesco Romani has posted comments on this change. Change subject: virt: Configurable actions on console disconnect ......................................................................
Patch Set 6: Code-Review-1 (1 comment) ok for the concept (besides naming nitpicking, not really important). Unfortunately, schema change is still missing, so -1. :\ https://gerrit.ovirt.org/#/c/34265/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1328: def _timedDesktopLock(self): Line 1329: if not self.conf.get('clientIp', ''): Line 1330: delay = config.get('vars', 'user_shutdown_timeout') Line 1331: timeout = config.getint('vars', 'sys_shutdown_timeout') Line 1332: CDA = ConsoleDisconnectAction this reads funny, but I don't have any suggestions about improvements. Line 1333: if self._consoleDisconnectAction == CDA.LOCK_SCREEN: Line 1334: self.guestAgent.desktopLock() Line 1335: elif self._consoleDisconnectAction == CDA.LOGOUT: Line 1336: self.guestAgent.desktopLogoff() -- To view, visit https://gerrit.ovirt.org/34265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d60a38ad89ed942f8e58e985178c27a165c724 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
