Francesco Romani has posted comments on this change. Change subject: virt: Configurable actions on console disconnect ......................................................................
Patch Set 6: Code-Review+1 turns out we don't need schema update, because the we set the new param through setTicket params, which is an opaque 'StringMap' already. hence, no need to change schema here. naming nitpicking is not worth delaying this patch, so +1. -- To view, visit https://gerrit.ovirt.org/34265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d60a38ad89ed942f8e58e985178c27a165c724 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
