Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/39343/4/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 99 Line 100 Line 101 Line 102 Line 103 > This is wrong - please see the original asyncore code which does not have t For xmlrpc is is done handle_dispatcher. it is called in handle_read. So the problematic piece of code is to running again handle_read in a loop. Line 95: self.handle_connect_event() Line 96: Line 97: self.handle_read() Line 98: Line 99: if hasattr(self.__impl, "recently_detected"): > for my understanding: how it is possible for __impl *not* to have this attr There is more than one dispatcher implementation that we use and not all of them have this method. Line 100: if self.__impl.recently_detected(): Line 101: return Line 102: Line 103: # we need to check whether there is pending function on Line 97: self.handle_read() Line 98: Line 99: if hasattr(self.__impl, "recently_detected"): Line 100: if self.__impl.recently_detected(): Line 101: return > This is the wrong solution. so the issue is that when we detect xmlrpc we remove it from asyncore processing map and we do not want to run handle_read. Line 102: Line 103: # we need to check whether there is pending function on Line 104: # our fd because we use eventfds which do not provide it Line 105: if hasattr(self.socket, "pending"): -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
