Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39343/5/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 54: self.connection.shutdown(socket.SHUT_RDWR) Line 55: self.connection.close() Line 56: # if we do not close socket we get ssl protocol shutdown Line 57: # but fd is not released Line 58: self.connection.socket.close() > Maybe the fix should go into m2c? I agree we can start the process to push it there. From my experience I know that it takes a lot of time to push anything there so let's have it in our code and when the fix is in m2c we can revert it. Line 59: Line 60: def fileno(self): Line 61: return self.connection.fileno() Line 62: -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches