Martin Polednik has posted comments on this change. Change subject: virt: add unit test for getUnderlying* family of methods ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/39364/1/tests/Makefile.am File tests/Makefile.am: Line 21: include $(top_srcdir)/build-aux/Makefile.subs Line 22: Line 23: SUBDIRS = \ Line 24: functional \ Line 25: device_tests \ > given that we are under tests/, do we really need the _tests suffix? Maybe, maybe not... probably not Line 26: $(NULL) Line 27: Line 28: test_modules = \ Line 29: alignmentScanTests.py \ https://gerrit.ovirt.org/#/c/39364/1/tests/device_tests/Makefile.am File tests/device_tests/Makefile.am: Line 25: xmlParsingTests.py \ Line 26: $(NULL) Line 27: Line 28: dist_vdsmdevtests_DATA = \ Line 29: testComplexVm.xml \ > pep8 names? I don't really mind, your call. +1, wasn't sure about pep8 module naming https://gerrit.ovirt.org/#/c/39364/1/tests/device_tests/xmlParsingTests.py File tests/device_tests/xmlParsingTests.py: Line 38: {'device': 'rng', 'specParams': {'source': 'random'}, Line 39: 'model': 'virtio', 'type': 'rng'}] Line 40: Line 41: domain = None Line 42: with open('./testComplexVm.xml', 'r') as domxml: > not sure about this path. Please look around tests/vmApiTests.py:42 for a I have no issue with using similar pathing, but I still need to open and read the file this way Line 43: domain = domxml.read() Line 44: Line 45: with fake.VM(params=params, devices=devices) as vm: Line 46: vm._domain = domain_descriptor.DomainDescriptor(domain) -- To view, visit https://gerrit.ovirt.org/39364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
