Ido Barkan has posted comments on this change. Change subject: virt: add unit test for getUnderlying* family of methods ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39364/1/tests/device_tests/xmlParsingTests.py File tests/device_tests/xmlParsingTests.py: Line 38: {'device': 'rng', 'specParams': {'source': 'random'}, Line 39: 'model': 'virtio', 'type': 'rng'}] Line 40: Line 41: domain = None Line 42: with open('./testComplexVm.xml', 'r') as domxml: > I have no issue with using similar pathing, but I still need to open and re usually this test will be run from /usr/share/vdsm/tests (not sure by the way how Jenkins runs it) so I think it's better just to compute the path, or use an ugly vdsm "vdsmtestsdir" constant :-) another considerable option is working with a big global xml string literal (pretty printed), which can also be parsed by domxml. Line 43: domain = domxml.read() Line 44: Line 45: with fake.VM(params=params, devices=devices) as vm: Line 46: vm._domain = domain_descriptor.DomainDescriptor(domain) -- To view, visit https://gerrit.ovirt.org/39364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
