Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: fd leak fix ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39506/2/vdsm/rpc/BindingXMLRPC.py File vdsm/rpc/BindingXMLRPC.py: Line 1198: client_socket = dispatcher.socket Line 1199: # We need to set socket to None in order to have Line 1200: # file descriptor released by m2c. Line 1201: # m2c releases fd in __del__ method Line 1202: dispatcher.socket = None > Setting the socket to None is good idea, although I suspect that we have a Agree. I started to explore how we can make sure that we close/release all dispatcher objects. Line 1203: dispatcher.del_channel() Line 1204: self.xml_binding.add_socket(client_socket, socket_address) -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
