Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: fd leak fix ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39506/3/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 160: raise Line 161: Line 162: def del_channel(self, map=None): Line 163: try: Line 164: del asyncore.socket_map[self._fileno] > Is this still needed after the unbinding? I checked and we need it to be garbage collectable. Line 165: except KeyError: Line 166: pass Line 167: asyncore.dispatcher.del_channel(self, map) Line 168: self._unbind_implementation() -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
