Francesco Romani has posted comments on this change. Change subject: virt: add unit test for getUnderlying* family of methods ......................................................................
Patch Set 2: (1 comment) nice work https://gerrit.ovirt.org/#/c/39364/2/tests/devices/parsing/complex_vm_tests.py File tests/devices/parsing/complex_vm_tests.py: Line 1: import os missing copyright boilerplate. IANAL, and for this very reason I want to play it safe :) Line 2: Line 3: from testlib import XMLTestCase Line 4: Line 5: from virt import domain_descriptor -- To view, visit https://gerrit.ovirt.org/39364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
