Yeela Kaplan has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39203/2/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 62: def migrationCreate(self, params): Line 63: self._callMethod(command_converter['migrationCreate'], Line 64: params['vmId'], Line 65: params) Line 66: return {'status': {'code': 0}} > Please use status from the _callMethod response We have to be compatible with the vdscli response... Do you have a suggestion for that? Line 67: Line 68: def __getattr__(self, methodName): Line 69: return partial(self._callMethod(methodName)) Line 70: Line 76: createStompClient > createStompClient can return None. Please make sure that we fail when we ge Done -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
