Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/39203/3/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 74: Line 75: def connect(cif, client_socket): Line 76: stompClient = cif.createStompClient(client_socket) Line 77: if stompClient is None: Line 78: raise Exception("Failed to create a stomp client") I don't see in the code how createStompClient can return None without explode .. I think this part is redundant Line 79: Line 80: client = JsonRpcClient(stompClient) Line 81: client.connect() Line 82: server = _Server(client) Line 77: if stompClient is None: Line 78: raise Exception("Failed to create a stomp client") Line 79: Line 80: client = JsonRpcClient(stompClient) Line 81: client.connect() In the other hand, the connect part seems like something that should be covered with errors handling Line 82: server = _Server(client) Line 83: Line 80: client = JsonRpcClient(stompClient) Line 81: client.connect() Line 82: server = _Server(client) Line 83: Line 84: return server just return _Server(client) -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
