Nir Soffer has posted comments on this change. Change subject: xmlrpc: fd leak fix ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39506/4/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 245: return Dispatcher( Line 246: impl=acceptor, Line 247: sock=sock, Line 248: map=self._map Line 249: ) Why the reactor should provide all types of dispatchers? I think it should be enough and better if the reactor will create one type of dispatcher, and the user will provide the implementation so you can write any dispatcher you need without changing this module. def create_dispatcher(impl, sock): return Dispatcher(impl, sock=sock, map=self._map) The calling code will do: class MyDispatcher(object): def handle_read(self): ... reactor.create_dispatcher(MyDispatcher, client_socket) Any reason that this will not work? Line 250: Line 251: def remove_dispatcher(self, disp): Line 252: disp.del_channel(self._map) Line 253: -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
