Martin Polednik has posted comments on this change. Change subject: virt: sampling: add StatsCache docs and tests ......................................................................
Patch Set 2: (I haven't seen the underlying code) almost, only if b would also have first and last sample - but this is probably sufficient (the test would go like having {a:1, b:3, b:4, a: 2} and checking that a -> (1,2) b->(3,4) but I'm unsure if there is any need for it) -- To view, visit https://gerrit.ovirt.org/39437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d23dacefef10b84337a897cc130f77d72b68dae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches