Francesco Romani has posted comments on this change. Change subject: virt: sampling: add StatsCache docs and tests ......................................................................
Patch Set 2: interesting point. Let me think. StatsCache must return for a given Vm, either - (None, None, None) - two samples, and the time interval among them Due to side effect of having a SampleWindow underneath, this mean that the two samples must be collected in two consecutive sampling cycles. Maybe I can improve the tests a bit more. -- To view, visit https://gerrit.ovirt.org/39437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d23dacefef10b84337a897cc130f77d72b68dae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
