Yeela Kaplan has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/36699/4/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 335: if not self._is_handshaking: Line 336: self._handshake_finished_handler(dispatcher) Line 337: Line 338: Line 339: def sslEnabled(): > We want only pep8 names in new code. Since this module does have yet any fu Done Line 340: return config.getboolean('vars', 'ssl') Line 341: Line 342: Line 343: def createSSLContext(): Line 339: def sslEnabled(): Line 340: return config.getboolean('vars', 'ssl') Line 341: Line 342: Line 343: def createSSLContext(): > Same, create_ssl_context Done Line 344: truststore_path = config.get('vars', 'trust_store_path') Line 345: key_file = os.path.join(truststore_path, 'keys', 'vdsmkey.pem') Line 346: cert_file = os.path.join(truststore_path, 'certs', 'vdsmcert.pem') Line 347: ca_cert = os.path.join(truststore_path, 'certs', 'cacert.pem') -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
