Nir Soffer has posted comments on this change. Change subject: vmdevices: move storage methods to storage module ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/40133/3/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 45: # TODO: use introspection Line 46: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT) Line 47: Line 48: Line 49: def spec_list_from_legacy_conf(conf, arch): Please move these functions to end of the module. Line 50: """ Line 51: Returns a list of drive specification dictionaries from legacy vm.conf Line 52: """ Line 53: conf_drives = conf.get('drives', []) Line 68: Line 69: return conf_drives Line 70: Line 71: Line 72: def __spec_list_from_legacy_direct_paths(conf): Don't use double underscores, one is enough Line 73: """ Line 74: Backward compatibility for qa scripts that specify direct paths. Line 75: """ Line 76: legacies = [] Line 84: 'truesize': 0}) Line 85: return legacies Line 86: Line 87: Line 88: def __spec_list_from_legacy_removable_drives(conf, arch): Same Line 89: removables = [{ Line 90: 'type': hwclass.DISK, Line 91: 'device': 'cdrom', Line 92: 'iface': DEFAULT_INTERFACE_FOR_ARCH[arch], -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
