Martin Polednik has posted comments on this change. Change subject: vmdevices: move storage methods to storage module ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 73: Line 74: def _spec_list_from_legacy_direct_paths(conf): Line 75: """ Line 76: Backward compatibility for qa scripts that specify direct paths. Line 77: """ > I don't want to support these qa scripts, only the documented api. Why wasn't the support removed before? Is it safe to remove or do we keep it as legacy? I've only copied the code from vm.py, not added it. Line 78: legacies = [] Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd')) Line 80: for index, linux_name in device_spec: Line 81: path = conf.get(linux_name) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
