Francesco Romani has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. ......................................................................
Patch Set 2: Code-Review-1 (2 comments) -1 for visibility. Proposal inside to hopefully make things easier. https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py File tests/samplingTests.py: Line 176: d This looks like a Fake, not a Mock Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample', Line 181: NumaNodeMemorySampleMock)]): Line 182: with dummy_if() as dummy_name: Line 183: with vlan(self.NEW_VLAN, dummy_name, 999): Line 184: hs = sampling.HostSample(os.getpid()) HostSample needs a lot of love, and unfortunately is pretty low on everyone's TODO. What about just calling interfaces = sampling._get_interfaces_and_sample() and avoid HostSample whenever possible? Should be good enough for your needs. Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces) Line 186: Line 187: Line 188: @expandPermutations -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
