Ido Barkan has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py File tests/samplingTests.py: Line 149: s1 = sampling.InterfaceSample(lo) Line 150: s1.operstate = 'x' Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0)) Line 152: Line 153: @brokentest("Broken unless libvirtd is running") this test also needs to be fixed in the same manner. Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password) Line 155: @ValidateRunningAsRoot Line 156: def testHostSampleReportsNewInterface(self): Line 157: hs_before = sampling.HostSample(os.getpid()) Line 176: d > This looks like a Fake, not a Mock after handling your other comment, this was thrown away Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample', Line 181: NumaNodeMemorySampleMock)]): Line 182: with dummy_if() as dummy_name: Line 183: with vlan(self.NEW_VLAN, dummy_name, 999): Line 184: hs = sampling.HostSample(os.getpid()) > HostSample needs a lot of love, and unfortunately is pretty low on everyone well, I guess I initially called HostSample constructor to catch future cases (and because that what the application does!) but I feel the pain. Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces) Line 186: Line 187: Line 188: @expandPermutations -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
