Francesco Romani has uploaded a new change for review.
Change subject: sampling: less verbose debug in _getInterfaceStats
......................................................................
sampling: less verbose debug in _getInterfaceStats
HostStatsThread._getInterfaceStats needs, among other
things, to compute network tx/rx rate.
To help troubleshoot rate miscalculation, there is
a debug log which shows all the samples used for
computation.
The problem here is that the log cycles over the
internal samples. We want to use SampleWindow
in HostStatsThread to reduce code duplication,
but SampleWindow doesn't give access to samples yet.
To move further, we drop this detailed log for the time
being. Future patches may want to reintroduce it
on top of (enhanced) SampleWindow.
Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Signed-off-by: Francesco Romani <from...@redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/40424/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index f5640d0..8878120 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -710,13 +710,7 @@
if txRate > 100 or rxRate > 100:
txRate = min(txRate, 100.0)
rxRate = min(rxRate, 100.0)
- self._log.debug('Rate above 100%%. DEBUG: ifid %s interval: '
- '%s thisRx %s thisTx %s samples %s', ifid,
- interval, thisRx, thisTx,
- [(hs.timestamp, hs.interfaces[ifid].rx,
- hs.interfaces[ifid].tx)
- for hs in self._samples if
- ifid in hs.interfaces])
+ self._log.debug('Rate above 100%%.')
iface = hs1.interfaces[ifid]
stats['network'][ifid] = {'name': ifid, 'speed': str(ifrate),
'rxDropped': str(iface.rxDropped),
--
To view, visit https://gerrit.ovirt.org/40424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
