Yeela Kaplan has posted comments on this change. Change subject: stomp: add an option to create a stomp client ......................................................................
Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/38491/5//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-04-21 11:24:09 +0300 Line 4: Commit: Yeela Kaplan <ykap...@redhat.com> Line 5: CommitDate: 2015-04-21 11:24:09 +0300 Line 6: Line 7: stomp: add an option to create a stomp client > Why protocol detector should be involved in creating a client? That was the idea at first - to get the reactor. But Piotr suggested that we don't want to get the reactor, but only a client. Line 8: Line 9: Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 https://gerrit.ovirt.org/#/c/38491/5/vdsm/clientIF.py File vdsm/clientIF.py: Line 184: return sslctx Line 185: Line 186: def createStompClient(self, connected_socket): Line 187: return self._acceptor.create_client(connected_socket, Line 188: 'stomp') > Why do we need a connected socket for creating a client? A client is suppos That's the way the reactor code is designed currently, so it's not a decision related to this patch. A broader explanation would state that json, stomp and the transport (socket) are three different layers, and that is why we already pass it a connected socket - the bottom layer ready already for the second layer. Line 189: Line 190: def _prepareXMLRPCBinding(self): Line 191: if config.getboolean('vars', 'xmlrpc_enable'): Line 192: try: https://gerrit.ovirt.org/#/c/38491/5/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 203: for handler in self._handlers: Line 204: if handler.NAME == "stomp": Line 205: return handler.createClient(connected_socket) Line 206: Line 207: return None > NotSupported ? TypeError? its up to Yeela. Done Line 208: Line 209: Line 210: class _CannotDetectProtocol(Exception): Line 211: pass -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
