Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used ......................................................................
Patch Set 3: Ido, I don't think this patch depends on the later one. It does one job: to split ifup into two functions, both of which have their users (ones that used 'async' before and the others that did not). You may notice that I removed unused 'returns' from both _ifups. I don't want to merge this patch with the later one because it does away with 'async', that's a different task. And while at it I took the opportunity to give the two descendant functions of ifup new names that indicate they are private to ifcfg, as you suggested. -- To view, visit https://gerrit.ovirt.org/40478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
