Petr Horáček has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40456/5/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 774: raise ConfigNetworkError(ERR_FAILED_IFUP, out[-1] if out else '') Line 775: Line 776: Line 777: def _ifup_nonblocking(iface): Line 778: if iface and not iface.blockingdhcp and (iface.ipv4.bootproto == 'dhcp' or why 'if iface' ? Line 779: iface.ipv6.dhcpv6): Line 780: # wait for dhcp in another thread, so vdsm won't get stuck (BZ#498940) Line 781: t = threading.Thread(target=_ifup, name='ifup-waiting-on-dhcp', Line 782: args=(iface.name,)) -- To view, visit https://gerrit.ovirt.org/40456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches