Just to make sure I understand. If javax.sql.DataSource is in the classpath, then DataSourceResourceLoader is included? But if javax.sql.DataSource is not, then it is not?

Can we display a user-friendly warning message (but compile anyway) if javax.sql.DataSource is not in the classpath. Something like "Excluding DataSourceResourceLoader from jar since javax.sql.DataSource is not in classpath. To compile this call, please download jdbc2_0-stdext.jar into your repository".

WILL

----- Original Message ----- From: "Henning P. Schmiedehausen" <[EMAIL PROTECTED]>
Newsgroups: hometree.jakarta.velocity.dev
To: <[email protected]>
Sent: Monday, September 19, 2005 1:52 PM
Subject: Re: [jira] Commented: (VELOCITY-402) First cut at a working and usable maven build for Velocity


"Will Glass-Husain (JIRA)" <[EMAIL PROTECTED]> writes:

[ http://issues.apache.org/jira/browse/VELOCITY-402?page=comments#action_12329898 ]

Will Glass-Husain commented on VELOCITY-402:
--------------------------------------------

On a related note, I think this issue applies:  VELOCITY-401

In a nutshell, I think we should remove all the "j2ee" targets and just include the DataSourceResourceLoader if javax.sql.DataSource is in the classpath. In ant this would be simple - can we do this with maven?

You didn't look at my patch, did you? ;-)

   <sourceModifications>
     <sourceModification>
       <className>javax.sql.DataSource</className>
       <excludes>

<exclude>**/org/apache/velocity/runtime/resource/loader/DataSourceResourceLoader.java</exclude>
       </excludes>
     </sourceModification>
   </sourceModifications>

does exactly that.

Best regards
Henning

--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
[EMAIL PROTECTED]        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
  Linux, Java, perl, Solaris -- Consulting, Training, Development

      4 - 8 - 15 - 16 - 23 - 42

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to